Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/win parallel port #138

Merged
merged 21 commits into from
Dec 2, 2024
Merged

Feature/win parallel port #138

merged 21 commits into from
Dec 2, 2024

Conversation

maartenuni
Copy link
Contributor

This implements a ParallelPort trigger interface for windows.

maartenuni and others added 18 commits November 13, 2024 08:40
This commit add support for enumeration of parallelports.
This is on the base class, as enumeration is platform specific
This function needs to be implemented in derived classes.
PsyTimePoints are BoxedTypes, instead of instances of GObject.
The code related to psy-parallel-trigger still used g_object_unref
on them. This commit will call correctly psy_time_point_free
on them.

fixes #136
Sleep(1), will sleep at least 1 ms on windows, but in practice
it sleeps for much longer e.g. +/- 10 times as long. For timing
stuff accuratly, psylib needs to busyloop until that time arives.
So in order to save energy, psylib sleeps for 1 ms until the
event we are sleeping for is less then 1 ms away, and then it will
start busy looping, until the event-time.

The code in [class.ParallelTrigger] was fine, however, it overslept
because Sleep issue mentionned above. Now TimeBeginPeriod is called
when initializing psylib and TimeEndPeriod is called when deinitialiing
psylib

This fixes #137
@maartenuni maartenuni added enhancement New feature or request windows Problems featurus related to the windows platform labels Dec 2, 2024
@maartenuni maartenuni self-assigned this Dec 2, 2024
@maartenuni maartenuni merged commit 6815e91 into develop Dec 2, 2024
6 checks passed
@maartenuni maartenuni deleted the feature/win-parallel-port branch December 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows Problems featurus related to the windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant